Maybe the issue is what RAT/Maven considers a binary and executable file on Windows vs. Linux? Doesn't RAT skip binary and executable files?
For me that means that this RC can only possibly accept +1 from folks on Linux. So if you get enough Linux +1s you're OK but for me, on Windows, I'll abstain. Gary On Thu, Sep 25, 2014 at 9:30 AM, Oleg Kalnichevski <[email protected]> wrote: > On Thu, 2014-09-25 at 09:00 -0400, Gary Gregory wrote: > > Using the source zip, the ONLY way I could get 'mvn apache-rat:check' to > > pass was to edit the pom.xml and do (now in SVN): > > > > Index: pom.xml > > =================================================================== > > --- pom.xml (revision 1627533) > > +++ pom.xml (revision 1626737) > > @@ -392,7 +392,6 @@ > > <configuration> > > <excludes> > > <exclude>src/docbkx/resources/**</exclude> > > - <exclude>src/test/resources/*.truststore</exclude> > > </excludes> > > </configuration> > > </plugin> > > > > How can others get this to work without this change is beyond me, can it > be > > attributed to Maven itself? > > > > I just ran the check with Maven 3.2.3 on the source tarball (not SVN > trunk) and it passed. I suspect this problem may have more to do with > Windows / Linux differences for some reason. > > --- > Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; > 2014-08-11T22:58:10+02:00) > Maven home: /opt/apache-maven-3.2.3 > Java version: 1.7.0_60, vendor: Oracle Corporation > Java home: /opt/oracle-jdk-1.7.0.60/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.13.0-36-generic", arch: "amd64", family: > "unix" > > --- > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Apache HttpClient 4.4-beta1 > [INFO] > ------------------------------------------------------------------------ > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default-cli) @ httpclient --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: src/docbkx/resources/** > [INFO] 550 resources included (use -debug for more details) > Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > Compiler warnings: > WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not > recognized.' > Warning: org.apache.xerces.parsers.SAXParser: Feature > 'http://javax.xml.XMLConstants/feature/secure-processing' is not > recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not > recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: > 0 approved: 546 licence. > [INFO] > [INFO] > ------------------------------------------------------------------------ > > Oleg > > > I use: > > > > Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; > > 2014-08-11T16:58:10-04:00) > > Maven home: C:\Java\apache-maven-3.2.3 > > Java version: 1.7.0_67, vendor: Oracle Corporation > > Java home: C:\Program Files\Java\jdk1.7.0_67\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > > > Gary > > > > On Tue, Sep 23, 2014 at 8:53 AM, Gary Gregory <[email protected]> > > wrote: > > > > > I ran: > > > > > > mvn test > > > mvn install -DskipTests > > > > > > and got: > > > > > > [INFO] Rat check: Summary of files. Unapproved: 2 unknown: 2 > generated: 0 > > > approved: 546 licence. > > > [INFO] > > > > ------------------------------------------------------------------------ > > > [INFO] Reactor Summary: > > > [INFO] > > > [INFO] Apache HttpComponents Client ....................... SUCCESS [ > > > 9.254 s] > > > [INFO] Apache HttpClient .................................. FAILURE [ > > > 44.541 s] > > > [INFO] Apache HttpClient Mime ............................. SKIPPED > > > [INFO] Apache HttpClient Fluent API ....................... SKIPPED > > > [INFO] Apache HttpClient Cache ............................ SKIPPED > > > [INFO] Apache HttpClient Windows features ................. SKIPPED > > > [INFO] Apache HttpClient OSGi bundle ...................... SKIPPED > > > [INFO] > > > > ------------------------------------------------------------------------ > > > [INFO] BUILD FAILURE > > > [INFO] > > > > ------------------------------------------------------------------------ > > > [INFO] Total time: 55.306 s > > > [INFO] Finished at: 2014-09-23T08:47:23-04:00 > > > [INFO] Final Memory: 46M/600M > > > [INFO] > > > > ------------------------------------------------------------------------ > > > [ERROR] Failed to execute goal > org.apache.rat:apache-rat-plugin:0.11:check > > > (default) on project httpclient: Too many files with unapproved > license: 2 > > > See RAT report in: > > > C:\temp\rc\httpcomponents-client-4.4-beta1\httpclient\target\rat.txt -> > > > [Help 1] > > > > > > that rat.txt: > > > > > > 2 Unknown Licenses > > > > > > ******************************* > > > > > > Unapproved licenses: > > > > > > > > > > C:/temp/rc/httpcomponents-client-4.4-beta1/httpclient/src/test/resources/hc-test-1.truststore > > > > > > > C:/temp/rc/httpcomponents-client-4.4-beta1/httpclient/src/test/resources/hc-test-2.truststore > > > > > > ******************************* > > > > > > Am I the only one to see this? > > > > > > I am on: > > > > > > Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; > > > 2014-08-11T16:58:10-04:00) > > > Maven home: C:\Java\apache-maven-3.2.3 > > > Java version: 1.8.0_20, vendor: Oracle Corporation > > > Java home: C:\Program Files\Java\jdk1.8.0_20\jre > > > Default locale: en_US, platform encoding: Cp1252 > > > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" > > > > > > Gary > > > > > > On Tue, Sep 23, 2014 at 4:52 AM, Oleg Kalnichevski <[email protected]> > > > wrote: > > > > > >> Please vote on releasing these packages as HttpComponents Client > > >> 4.4-beta1. > > >> The vote is open for the at least 72 hours, and only votes from > > >> HttpComponents PMC members are binding. The vote passes if at least > > >> three binding +1 votes are cast and there are more +1 than -1 votes. > > >> > > >> Release notes: > > >> > > >> > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-beta1-RC1/RELEASE_NOTES-4.4.x.txt > > >> > > >> Maven artefacts: > > >> > > >> > https://repository.apache.org/content/repositories/orgapachehttpcomponents-1017 > > >> > > >> SVN tag: > > >> > > >> > https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-beta1-RC1 > > >> revision 1626788 > > >> > > >> Packages: > > >> > > >> > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-beta1-RC1 > > >> revision 6625 > > >> > > >> Hashes: > > >> 92cd275384a86c3128a4d4e571dc6cf8 > > >> httpcomponents-client-4.4-beta1-bin.tar.gz > > >> 7d51f3995dad78a460fe688c80887d96 > > >> httpcomponents-client-4.4-beta1-osgi-bin.tar.gz > > >> 2a1b26a5a10384a02016d072ee0fea98 > > >> httpcomponents-client-4.4-beta1-src.tar.gz > > >> 4b42702dbee595784bc51ad9fbb5e989 > httpcomponents-client-4.4-beta1-bin.zip > > >> 5854a9ee84b8310d6d5f06e5c4471abf > > >> httpcomponents-client-4.4-beta1-osgi-bin.zip > > >> 9aa734af5a3987c9d97cf932efb5d29c > httpcomponents-client-4.4-beta1-src.zip > > >> > > >> Keys: > > >> http://www.apache.org/dist/httpcomponents/httpclient/KEYS > > >> > > >> > -------------------------------------------------------------------------- > > >> Vote: HttpComponents Client 4.4-beta1 release > > >> [ ] +1 Release the packages as HttpComponents Client 4.4-beta1. > > >> [ ] -1 I am against releasing the packages (must include a reason). > > >> > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > >> > > > > > > > > > -- > > > E-Mail: [email protected] | [email protected] > > > Java Persistence with Hibernate, Second Edition > > > <http://www.manning.com/bauer3/> > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > > Spring Batch in Action <http://www.manning.com/templier/> > > > Blog: http://garygregory.wordpress.com > > > Home: http://garygregory.com/ > > > Tweet! http://twitter.com/GaryGregory > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
