[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156380#comment-14156380
 ] 

Karl Wright commented on HTTPCLIENT-1557:
-----------------------------------------

Hi,

The NTLM interaction was initially written to specification, as you may see in 
the comments.  Later, due to the fact that some versions of Windows and some 
3rd-party NTLM implementations don't precisely adhere to that spec, certain 
functionality was disabled.  It is by no means clear if or when conditional 
implementation may be needed.  For that reason, assembly of the fields that 
were disabled has been left in place; this could be replaced by a comment, but 
probably it would not be the right thing to do to structurally reorganize the 
NTLM engine based on current usage.


> NTLMEngine.Type1Message doesn't do anything with domain and host
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1557
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1557
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.6
>            Reporter: Stéphane Landelle
>
> Since 4.2.3, NTLMEngine.Type1Message doesn't actually do anything with domain 
> and host parameters. It computes bytes from them, but don't do anything with 
> those.
> Is this intended? I get that domain and host are optional, but should they 
> really be completely ignored?
> If so, Type1Message could be turned as a singleton, as the message ends up 
> being always the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to