Atkins created HTTPCLIENT-1577:
----------------------------------

             Summary: Some setting may not take effect if  assigned 
HttpClientConnectionManager instance in HttpClientBuilder
                 Key: HTTPCLIENT-1577
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1577
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpClient
    Affects Versions: 4.3.3
            Reporter: Atkins


If use set {code}setConnectionManager{code} method in {code} 
HttpClientBuilder{code}, some method like {code}setDefaultSocketConfig{code} or 
{code}setDefaultConnectionConfig{code} may not take effect.
Should throw exception, write in javadoc or remove these method because it is 
duplicated. User should use {code}connectionManagerBuilder{code} to create 
custom connectionManager and use {code}setConnectionManager{code} to set it.

example code:
{code}
HttpClients.custom()
         .setConnectionManager(...)
         .setDefaultSocketConfig(...)
         .setDefaultConnectionConfig(...)
         .setSSLSocketFactory(...)
         .setMaxConnTotal()
         .setMaxConnTotal()
         .build();
{code}

All setXXX below setConnectionManager will not take any effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to