On Mon, Jan 26, 2015 at 4:11 AM, Oleg Kalnichevski <[email protected]> wrote:
> On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> > Running 'mvn test' I get:
> >
> > Failed tests:
> > TestHttpRoute.testTargetHostNormalizationAddress:619
> > expected:<[localhost]> but was:<[127.0.0.1]>
> >
> > Using:
> >
>
> Gary
>
> This is clearly not a defect, but what appears to be Windows specific
> behavior.
>
If you say so, I am only testing on Windows. There is no way for me to know
or tell that this is Windows specific. I see you removed:
Assert.assertEquals("localhost", targetHost.getHostName());
If this is expected to pass on non-Windows then perhaps the assert should
be in a special test method with a JUnit Assume that only passes on
non-Windows.
Or is the behavior of the method "underfined" WRT to 'transformations'?
Did the behavior change between releases? Is this going to be a
compatibility issue?
>
> I removed the assert in SVN trunk:
> http://svn.apache.org/r1654745
>
> Is this issue a release blocker for you?
>
You make it sound like it shouldn't be a blocker but that means anyone
evaluating the RC on Windows will run into this failure. I guess I could
tell Maven to skip the one test but I do not think I can do that from the
command line as opposed to the POM.
Since it seems you are confident this is not an issue and I cannot run a
full build, I will vote 0: cannot run full build on Windows, one test fails"
Gary
> Oleg
>
> >
> > On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <[email protected]>
> wrote:
> >
> > > Please vote on releasing these packages as HttpComponents Client 4.4.
> > > The vote is open for the at least 72 hours, and only votes from
> > > HttpComponents PMC members are binding. The vote passes if at least
> > > three binding +1 votes are cast and there are more +1 than -1 votes.
> > >
> > > Release notes:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
> > >
> > > Maven artefacts:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
> > >
> > > SVN tag:
> > >
> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
> > > revision 1654497
> > >
> > > Packages:
> > >
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
> > > revision 7821
> > >
> > > Hashes:
> > > 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
> > > 7cf0df5a8d29b08185f909a4099a8030
> httpcomponents-client-4.4-osgi-bin.tar.gz
> > > ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
> > > 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
> > > 1c801772176fbcc4385fd0ac8454c310
> httpcomponents-client-4.4-osgi-bin.zip
> > > 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
> > >
> > > Keys:
> > > http://www.apache.org/dist/httpcomponents/httpclient/KEYS
> > >
> > >
> --------------------------------------------------------------------------
> > > Vote: HttpComponents Client 4.4 release
> > > [ ] +1 Release the packages as HttpComponents Client 4.4.
> > > [ ] -1 I am against releasing the packages (must include a reason).
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [email protected]
> > > For additional commands, e-mail: [email protected]
> > >
> > >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
--
E-Mail: [email protected] | [email protected]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
