[
https://issues.apache.org/jira/browse/HTTPCLIENT-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcos Scriven updated HTTPCLIENT-1607:
---------------------------------------
Description:
While writing a custom {{AuthScheme}}, I needed to add multiple headers to the
request.
This is of course possible just by directly adding them to the request
available as a parameter, but then it makes the return value rather arbitrary.
Returning null seems to work, and is just silently ignored.
I think it would be more intuitive to change the interface to return a
{{HeaderGroup}} instead.
I guess an alternative would be to write a custom filter somewhere, but that
wouldn't tie in nicely with authentication caches and user credentials
automatically being applied according to the host route.
was:
While writing a custom {{AuthScheme}}, I needed to add multiple headers to the
request.
This is of course possible just by directly adding them to the request
available as a parameter, but then it makes the return value rather arbitrary.
Returning null seems to work, and is just silently ignored.
I think it would be more flexible to change the interface to return a
`HeaderGroup`.
I guess an alternative would be to write a custom filter somewhere, but that
wouldn't tie in nicely with authentication caches and user credentials
automatically being applied according to the host route.
> Change ContextAwareAuthScheme.authenticate to return a HeaderGroup instead of
> a single Header
> ---------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1607
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1607
> Project: HttpComponents HttpClient
> Issue Type: Wish
> Components: HttpClient
> Affects Versions: 4.3.6
> Reporter: Marcos Scriven
> Priority: Minor
> Fix For: 4.4 Final
>
>
> While writing a custom {{AuthScheme}}, I needed to add multiple headers to
> the request.
> This is of course possible just by directly adding them to the request
> available as a parameter, but then it makes the return value rather
> arbitrary. Returning null seems to work, and is just silently ignored.
> I think it would be more intuitive to change the interface to return a
> {{HeaderGroup}} instead.
> I guess an alternative would be to write a custom filter somewhere, but that
> wouldn't tie in nicely with authentication caches and user credentials
> automatically being applied according to the host route.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
