[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519782#comment-14519782
 ] 

mrwolf commented on HTTPCLIENT-1644:
------------------------------------

1. The simplest TestCase attached.

2. javadoc  formatCookies of CookieSpec interface announces it might throw 
IllegalArgumentException, which is just like NPEx RunTime one of course, but 
NPEx is not mentioned :)

3. Maybe some earlier (RequestAddCookies?) call in my stacktrace didn't prepare 
the list "correctly", i.e. as expected by DefaultCookieCSpec implementation. 
Should I have more info for details, I'll be back and update.

> NullPointerException during DefaultCookieSpec.formatCookies call
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1644
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1644
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.4.1
>            Reporter: mrwolf
>            Priority: Minor
>         Attachments: DefaultCookieSpecTest.java
>
>
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.http.impl.cookie.DefaultCookieSpec.formatCookies(DefaultCookieSpec.java:191)
>         at 
> org.apache.http.client.protocol.RequestAddCookies.process(RequestAddCookies.java:186)
>         at 
> org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:132)
>         at 
> org.apache.http.protocol.HttpRequestExecutor.preProcess(HttpRequestExecutor.java:166)
>         at 
> org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:485)
>         at 
> org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:882)
>         at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
>         at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55)
> Current version of 
> https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java::formatCookies
>  is still vulnerable (if cookies contains null(s)).
> Maybe if cookie is null in that loop - it could be skipped?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to