[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952931#comment-14952931
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1688:
-----------------------------------------------

I am not sure what kind of answer you have expected. ProxySelectorRoutePlanner 
is deprecated. SchemeRegistry is deprecated. Generally we stop fixing code 
deprecated after a few releases (unless the defect represents a security 
vulnerability).

Having said that if you submit a PR at Github I'll review and commit it.

Oleg

> ProxySelectorRoutePlanner doesn't handle IllegalStateException thrown by 
> SchemeRegistry.getScheme
> -------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1688
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1688
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5
>            Reporter: Tobias Oberlies
>
> Unlike e.g. the {{DefaultHttpRoutePlanner}}, the 
> {{ProxySelectorRoutePlanner}} doesn't handle the {{IllegalStateException}} 
> that is thrown by {{SchemeRegistry.getScheme}} when using an unknown scheme. 
> This means that the {{IllegalStateException}} is thrown all the way to the 
> caller, e.g. {{HttpClient.execute}}.
> I suppose that the exception should be handled and converted into one of the 
> checked exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to