[
https://issues.apache.org/jira/browse/HTTPCLIENT-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073445#comment-15073445
]
ASF GitHub Bot commented on HTTPCLIENT-1709:
--------------------------------------------
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/40#issuecomment-167711849
Committed to git master. Please verify and close. In Apache's Jira as
[HTTPCLIENT-1709].
> Delete obsolete clone method
> ----------------------------
>
> Key: HTTPCLIENT-1709
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1709
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpCache
> Affects Versions: 4.5.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_65, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_65\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 5.0
>
>
> GitHub user meggermo opened a pull request:
> https://github.com/apache/httpclient/pull/40
> Delete obsolete clone method
> In svn revision 980937 the Cloneable interface was removed from the class
> CacheEntity but the clone method was not. Assuming the removal of the
> Cloneable interface was intentional, the clone method should have been
> removed as well.
> See https://fisheye6.atlassian.com/changelog/httpcomponents?cs=980937 for
> the entire change set.
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/meggermo/httpclient clone-method-unnecessary
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/httpclient/pull/40.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #40
> ----
> commit 1faa798a46f629824c4ba7b51b788c94b37a02e9
> Author: Michiel Eggermont <[email protected]>
> Date: 2015-12-28T11:26:34Z
> Delete clone method
> In svn revision 980937 the Cloneable interface was removed
> from the CacheEntity but the clone method was not.
> Assuming the removal of the Cloneable interface was
> intentional, the clone method should have been removed
> as well.
> ----
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
