[
https://issues.apache.org/jira/browse/HTTPCLIENT-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075598#comment-15075598
]
ASF GitHub Bot commented on HTTPCLIENT-1710:
--------------------------------------------
GitHub user enenum opened a pull request:
https://github.com/apache/httpclient/pull/41
HTTPCLIENT-1710 - fixes - examine all exceptions, correct capture group
count
Also in case there are more than one ProxyConfiguration services
registered, the proxy from the first enabled one encountered will be used. From
the user perspective, they have no control over which one that is. The whole
idea of multiple ProxyConfigurations (its a factory) seems largely unsupported
at this time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enenum/httpclient trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit c6857dbaef14fa52514ea0ba089e079c44d81c82
Author: 212427891 <[email protected]>
Date: 2015-12-31T00:13:15Z
HTTPCLIENT-1710 - fixes - examine all exceptions, correct capture groups
count
commit 85c5bcc4f66cf286e27312d3e67646badc6343f9
Author: 212427891 <[email protected]>
Date: 2015-12-31T01:19:59Z
HTTPCLIENT-1710 - adding tests for OSGiHttpRoutePlanner
----
> OSGiRoutePlanner examines only the first proxy exception and also crashes
> processing IP address exception
> ---------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1710
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1710
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.4.1, 4.5, 5.0
> Environment: OSGi
> Reporter: munene kiruja
> Fix For: 5.0
>
> Attachments: OSGiHttpRoutePlanner.java, TestOSGiHttpRoutePlanner.java
>
>
> The HttpClientBuilderFactory and internal RoutePlanner objects are a
> fantastic addition since 4.3.
> There are couple minor bugs rendering them unusable at the moment though.
> 1. The OSGiRoutePlanner.determinProxy() method only examines the first proxy
> exception.
> 2. When OSGiRoutePlanner.determinProxy() is creating a NetworkAddress from a
> String IP address, it refers to the 6th capture group in a case where there
> are only four, leading to an out of bounds exception.
> The class file is attached containing fixes for both issues at the 4.4.1
> version. I checked and found both issues existing in the trunk (5.0) at the
> time of this writing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
