[
https://issues.apache.org/jira/browse/HTTPCLIENT-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174988#comment-15174988
]
ASF GitHub Bot commented on HTTPCLIENT-1726:
--------------------------------------------
GitHub user dbaxa opened a pull request:
https://github.com/apache/httpclient/pull/47
HTTPCLIENT-1726: Copy the SNI fix from SSLConnectionSocketFactory to …
…the deprecated SSLSocketFactory class.
Signed-off-by: David Black <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dbaxa/httpclient HTTPCLIENT-1726
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 3c4059d1e5a38bae61d3b0a7d92adb1ab43eb4df
Author: David Black <[email protected]>
Date: 2016-03-02T03:47:06Z
HTTPCLIENT-1726: Copy the SNI fix from SSLConnectionSocketFactory to the
deprecated SSLSocketFactory class.
Signed-off-by: David Black <[email protected]>
----
> The deprecated SSLSocketFactory does not contain the fix for SSLSocketFactory
> -----------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1726
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1726
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.4.1, 4.5.1
> Reporter: David
> Labels: SNI
> Attachments: sni.patch
>
>
> Inside the deprecated [SSLSocketFactory.createSocket(final HttpContext
> context)|https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLSocketFactory.java#L521]
> method the fix that was applied for HTTPCLIENT-1119 is not present, see
> https://github.com/apache/httpclient/commit/92b7e8cd971868505d0f22ee5cfc12a68ee91b80
> for the fix for HTTPCLIENT-1119. That is, the method needs to create and
> return a standard socket, which is then layered on top of such that SNI is
> enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
