Charles Allen created HTTPCLIENT-1727:
-----------------------------------------
Summary:
org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager
Does not account for context class loader
Key: HTTPCLIENT-1727
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1727
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient
Affects Versions: 4.5.2, 4.5.1, 4.5, 4.4.1
Reporter: Charles Allen
org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager
Does not account for context class loader.
This means that only ClientConnectionManager factories visible in
AbstractHttpClient's classloader are loadable by AbstractHttpClient
An example of a failure here is if httpclient and jets3t are loaded in
different classloaders, where jets3t is in a child classloader of httpclient's
classloader. In such a case httpclient classes will be visible to jets3t, but
jets3t's classes will not be visible to httpclient so
org.jets3t.service.utils.RestUtils$ConnManagerFactory will not be found.
The proposed fix is as follows:
diff --git
a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
index 18a42d7..34c6e0f 100644
---
a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
+++
b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
@@ -327,9 +327,15 @@ public abstract class AbstractHttpClient extends
CloseableHttpClient {
final String className = (String) params.getParameter(
ClientPNames.CONNECTION_MANAGER_FACTORY_CLASS_NAME);
+ final ClassLoader contextLoader =
Thread.currentThread().getContextClassLoader();
if (className != null) {
try {
- final Class<?> clazz = Class.forName(className);
+ final Class<?> clazz;
+ if(contextLoader != null) {
+ clazz = Class.forName(className, true, contextLoader);
+ } else {
+ clazz = Class.forName(className);
+ }
factory = (ClientConnectionManagerFactory) clazz.newInstance();
} catch (final ClassNotFoundException ex) {
throw new IllegalStateException("Invalid class name: " +
className);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
