Tom Fitzhenry created HTTPCORE-422:
--------------------------------------
Summary: HttpAsyncRequestExecutor#responseReceived calls
HttpAsyncResponseConsumer#responseReceived(HttpResponse), even for HEAD requests
Key: HTTPCORE-422
URL: https://issues.apache.org/jira/browse/HTTPCORE-422
Project: HttpComponents HttpCore
Issue Type: Improvement
Components: HttpCore NIO
Affects Versions: 4.4.4
Reporter: Tom Fitzhenry
Priority: Minor
HttpAsyncRequestExecutor#responseReceived(NHttpClientConnection) calls
HttpAsyncResponseConsumer#responseReceived(HttpResponse) via
HttpAsyncClientExchangeHandler#responseReceived(HttpResponse).
See
https://github.com/apache/httpcore/blob/4.4.x/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java#L302
.
It does this even if the request is a HEAD request. If your
HttpAsyncResponseConsumer is a BasicAsyncResponseConsumer, then this will
allocate a buffer of size content-length kB (or 4kB, if content-length does not
exist).
For a simple proxying Java app, profiling revealed this the allocation due to
this was a bottleneck.
It'd be nice if
Are there use cases for calling
HttpAsyncResponseConsumer#responseReceived(HttpResponse) on HEAD requests? If
not, perhaps it could not be called.
FWIW, it looks like httpclient doe not call the corresponding method for HEAD
requests:
https://github.com/apache/httpcore/blob/4.4.x/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java#L273-L275
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
