[
https://issues.apache.org/jira/browse/HTTPCLIENT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348475#comment-15348475
]
ASF GitHub Bot commented on HTTPCLIENT-1748:
--------------------------------------------
GitHub user sebastiencaille opened a pull request:
https://github.com/apache/httpclient/pull/52
4.5.x
Hello,
Here is a pull request for HTTPCLIENT-1748 for httpclient 4.5.x. The first
change is the fix, the second one is an improvement.
I also implemented the fix for httpclient5. Should I submit it as a
separate pull request, or do you have a specific way to handle such case?
(rebase, ...)
Thanks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sebastiencaille/httpclient 4.5.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit c11d6f52889392e2492398f0b8d62fcb4d19108e
Author: Sebastien Caille <[email protected]>
Date: 2016-06-24T15:11:26Z
HTTPCLIENT-1748: fixed proxy authentication so it works with java
applets (started with firefox)
commit 59c2405c3991b464eb416473a597b9ce89fc2176
Author: Sebastien Caille <[email protected]>
Date: 2016-06-24T15:20:56Z
HTTPCLIENT-1748: improved creation of proxy's HttpHost
----
> When run in java applet, SystemDefaultCredentialsProvider fails to get
> authentication from Authenticator
> --------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1748
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1748
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.5
> Environment: Windows, application running in a java applet started by
> firefox, connection to a remote server via a squid proxy with basic
> authentication
> Reporter: Sébastien Caille
> Priority: Trivial
>
> Hello,
> The java applets are deprecated, but the issue may impact other use cases.
> During a POST call made from a java applet via a proxy server with basic
> authentication, SystemDefaultCredentialsProvider.getSystemCreds(...) calls
> Authenticator.requestPasswordAuthentication, which wrongly returns "null"
> authentication.
> The java applet console shows that a NullPointerException was ignored.
> I managed to fix the issue by providing the following values to
> Authenticator.requestPasswordAuthentication (getSystemCreds is currently
> providing null for those ones ):
> prompt = authscope.getRealm()
> url = context.getAttribute(HttpClientContext.HTTP_TARGET_HOST)
> Both values are needed ( prompt == null && url != null -> dialog box asking
> for credentials, prompt != null && url == null -> crashes firefox)
> Note that when downloading the applet jar files, the java is providing values
> for all the parameters of Authenticator.requestPasswordAuthentication
> (according to a breakpoint in requestPasswordAuthentication).
> Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
