GitHub user lewijw opened a pull request:

    https://github.com/apache/httpcore/pull/32

    HTTPCORE-439: Basicheader override of equals and hashcode

    When removing headers from a HeaderGroup, the header is only removed if the 
header you are trying to remove is an object in the header list. It seems it 
would be better if headers were removed that matched the name and value of one 
of the objects in the list. To accomplish this, I have overridden the equals 
and hashCode methods in BasicHeader.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lewijw/httpcore 
basicheader_override_of_equals_and_hashcode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit acd17adfa2a57b4eb50e231ca4565100b1c402e4
Author: John W. Lewis <[email protected]>
Date:   2016-12-21T21:12:19Z

    HTTPCORE-439: Contribute BasicHeader override of equals and hashcode

commit b197d174764f66e61e55edb118594db3747a8a6c
Author: John W. Lewis <[email protected]>
Date:   2016-12-21T21:12:19Z

    HTTPCORE-439: Contribute BasicHeader override of equals and hashcode

commit 89c1a97d12e6d41fddc919a4f6d269ef3e8e1197
Author: John W. Lewis <[email protected]>
Date:   2016-12-21T21:15:53Z

    Merge branch 'basicheader_override_of_equals_and_hashcode' of 
https://github.com/lewijw/httpcore into 
basicheader_override_of_equals_and_hashcode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to