It might be better to have a constant for new byte[0] Gary
---------- Forwarded message ---------- From: <[email protected]> Date: Fri, Mar 17, 2017 at 10:06 PM Subject: svn commit: r1787500 - /httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/CredSspScheme.java To: [email protected] Author: kwright Date: Fri Mar 17 21:06:06 2017 New Revision: 1787500 URL: http://svn.apache.org/viewvc?rev=1787500&view=rev Log: NPE fix related to HTTPCLIENT-1834. Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/ main/java/org/apache/http/impl/auth/CredSspScheme.java Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/ main/java/org/apache/http/impl/auth/CredSspScheme.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/ branches/4.5.x/httpclient/src/main/java/org/apache/http/ impl/auth/CredSspScheme.java?rev=1787500&r1=1787499&r2=1787500&view=diff ============================================================ ================== --- httpcomponents/httpclient/branches/4.5.x/httpclient/src/ main/java/org/apache/http/impl/auth/CredSspScheme.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/ main/java/org/apache/http/impl/auth/CredSspScheme.java Fri Mar 17 21:06:06 2017 @@ -566,6 +566,9 @@ public class CredSspScheme extends AuthS private byte[] encodeUnicode( final String string ) { + if (string == null) { + return new byte[0]; + } return string.getBytes( UNICODE_LITTLE_UNMARKED ); } -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
