[
https://issues.apache.org/jira/browse/HTTPCLIENT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935303#comment-15935303
]
ASF GitHub Bot commented on HTTPCLIENT-1835:
--------------------------------------------
GitHub user theangrydev opened a pull request:
https://github.com/apache/httpclient/pull/72
HTTPCLIENT-1835: evictExpiredConnections no longer causes the
evictIleConnections behaviour to be enabled when evictIdleConnections is not
explicitly enabled (4.6.x)
Same as #70 but for 4.6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/theangrydev/httpclient 4.6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 2ae9f2086011ea9f0459b8244b170e51120f6b3d
Author: Liam Williams <[email protected]>
Date: 2017-03-20T21:44:19Z
HTTPCLIENT-1835: evictExpiredConnections no longer causes the
evictIdleConnections behaviour to be enabled when evictIdleConnections is not
explicitly enabled
----
> evictExpiredConnections does not work as intended
> -------------------------------------------------
>
> Key: HTTPCLIENT-1835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1835
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (async), HttpClient (classic)
> Affects Versions: 4.5.4, 5.0 Alpha3
> Reporter: Liam Williams
>
> HttpClientBuilder and HttpAsyncClientBuilder have an evictExpiredConnections
> method that is supposed to allow configuring a client that will evict expired
> connections.
> When evictExpiredConnections is used alongside evictIdleConnections,
> everything is fine.
> However, if evictExpiredConnections is used without evictIdleConnections,
> currently the builder will default to also providing the evictIdleConnections
> behaviour (defaulting to evicting idle connections after 10 seconds).
> The correct behaviour in this case is to only provide the
> evictExpiredConnections behaviour and not the evictIdleConnections behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
