On Sun, Mar 26, 2017 at 10:43 AM, Oleg Kalnichevski <[email protected]> wrote:
> On Sun, 2017-03-26 at 03:43 +0000, [email protected] wrote: > > Author: ggregory > > Date: Sun Mar 26 02:43:03 2017 > > New Revision: 1788709 > > > > URL: http://svn.apache.org/viewvc?rev=1788709&view=rev > > Log: > > Use final. > > > > Gary, > > I have been meaning to say that for a long time. Keeping on making > style changes that are not enforced by the style check seems, well, I > do not know, a bit unwise. > > All this time would probably be much better spent improving the style > check definitions. > > http://svn.apache.org/repos/asf/httpcomponents/hc-stylecheck/trunk/src/ > main/resources/hc-stylecheck/default.xml > > ... > > > httpcomponents/httpclient/trunk/httpclient5/src/examples/org/apac > > he/hc/client5/http/examples/AsyncClientConnectionEviction.java > > httpcomponents/httpclient/trunk/httpclient5/src/examples/org/apac > > he/hc/client5/http/examples/AsyncClientHttp1Pipelining.java > > Code examples were not using final intentionally in order to make them > less noisy. Besides, not everyone likes explicit final variable > declarations. > > Examples intentionally use minimal style checks. > > http://svn.apache.org/repos/asf/httpcomponents/hc-stylecheck/trunk/src/ > main/resources/hc-stylecheck/minimal.xml > > *sigh* > I had no idea that file even existed, arg. Yeah, I do see the point about improving the checkstyle definitions. I wonder if checkstyle supports saying 'final' in the places Eclipse found missing. Gary > > Oleg > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
