On Mon, Apr 3, 2017 at 9:06 AM, Oleg Kalnichevski <[email protected]> wrote:
> On Sun, 2017-04-02 at 15:07 -0700, Gary Gregory wrote: > > On Thu, Feb 16, 2017 at 6:47 AM, sebb <[email protected]> wrote: > > > > ... > > > > > > So now yes, I can see a reason for a Timeout subclass. > > > > I can see in the code (e.g. > > org.apache.hc.core5.http.HttpConnection.getSocketTimeout()) where > > timeouts > > with values of 0 and -1 are special with 0 = disabled and -1 = > > undefined. > > > > So I could see factory methods like Timeout.disabled() and > > Timeout.undefined() that return singletons; or just define public > > statics. > > > > Then the code could call aTimeout.isDisabled()/isUndefined() instead > > of > > comparing to magic numbers. > > > > Thoughts? > > > > Gary > > > > Sounds good to me. I would also make it illegal to create Timeout > instances with negative duration. > I have a first cut of the Timeout class in svn trunk. It allows for a -1 timeout as a special case so I wonder if we want to hide that more. Also there is some awkwardness to the two isUndefined*() methods. Tweaks and comments appreciated. Gary > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
