[ 
https://issues.apache.org/jira/browse/HTTPCORE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015359#comment-16015359
 ] 

Oleg Kalnichevski commented on HTTPCORE-466:
--------------------------------------------

Gary

The patch looks dirty. For some reason more than a dozen lines of code get 
removed and then added verbatim [1]. I would not just blindly copy release 
notes of the previous release. What is the point doing that?

Oleg

[1] 
https://github.com/apache/httpcomponents-core/commit/346b4bb5170eb5bb9314a77bfa38f1c3a7df9235#diff-d4130987e8b64196e427456fb7ec79e2L614

> Round out the SslContextBuilder by adding missing APIs
> ------------------------------------------------------
>
>                 Key: HTTPCORE-466
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-466
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 4.4.7, 5.0-alpha4
>
>
> Round out the {{SslContextBuilder}} class by adding missing APIs that are 
> currently hard-coded as:
> - {{TrustManagerFactory.getDefaultAlgorithm()}}
> - {{KeyStore.getDefaultType()}}
> - {{KeyManagerFactory.getDefaultAlgorithm()}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to