I've confirmed that the proposed fix works in the expected way. I've created HTTPCLIENT-1859 for this work.
Now all I need to do is relearn how to work with HttpClient since I think you've finally moved to Git now? If you are still on SVN, please let me know what branch I should be committing to; if not, please give the magical command line git command to set myself up with the httpclient repository so I can code a fix. Thanks, Karl On Wed, Jun 21, 2017 at 9:59 AM, Oleg Kalnichevski <ol...@apache.org> wrote: > On Wed, 2017-06-21 at 06:38 -0400, Karl Wright wrote: > > Hi Oleg et al, > > > > ManifoldCF is having an issue with some repositories that use > > filenames > > that contain spaces and quotes. Specifically, when we send this data > > as a > > multipart form to Solr, it doesn't get properly interpreted. I've > > chased > > this down to the filename addendum of the Content Disposition header > > for > > the body, which has both "name" and "filename" subsections, and the > > "filename" subsection is just jammed in there between quotes (see > > FormBodyPartBuilder.java). That greatly constrains what can be used > > as a > > file name etc. > > > > There is apparently an encoding that you're supposed to do for > > filenames, > > that Httpclient isn't doing: > > > > https://stackoverflow.com/questions/18634337/how-to-set-filename-cont > > aining-spaces-in-content-disposition-header > > > > Should we attempt to add this encoding logic to the form body part > > builder? It would seem appropriate since httpclient is constructing > > the > > header. > > > > > > Karl > > Please do. > > Cheers > > Oleg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
