[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059263#comment-16059263
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1859:
-----------------------------------------------

[~kwri...@metacarta.com], The fix itself looks reasonable to me. Ideally it 
should have some test code with it as I believe it can be reasonably easily 
unit tested. 

It would also make things much easier if you could commit your changes either 
to a dev branch in the project repository or to your personal fork on GitHub.

Oleg

> FormBodyPartBuilder.java does not properly escape the name and filename 
> subfields in the ContentDisposition header
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1859
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1859
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>         Attachments: HTTPCLIENT-1859.patch
>
>
> The ContentDisposition header, used in multi-part forms, has a name and 
> filename subfield; these need to be escaped using unix-standard backslash 
> character stuffing, but FormBodyPartBuilder does not currently do this.  It 
> should.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to