[
https://issues.apache.org/jira/browse/HTTPCORE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062461#comment-16062461
]
Gary Gregory commented on HTTPCORE-454:
---------------------------------------
Hi Oleg,
I reviewed the changes and they all look good.
The only add-on we could provide is a utility to replace the pattern:
aTimeout != null ? aTimeout : Timeout.ZERO_MILLISECONDS
with:
Timeout.notNull(aTimeout, Timeout.ZERO_MILLISECONDS)
Not sure about the method name though
Gayr
Gary
> Add a Timeout class that extends TimeValue
> ------------------------------------------
>
> Key: HTTPCORE-454
> URL: https://issues.apache.org/jira/browse/HTTPCORE-454
> Project: HttpComponents HttpCore
> Issue Type: New Feature
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 5.0
>
>
> Add a {{Timeout}} class that extends {{TimeValue}}. {{Timeout}} will validate
> input so that you cannot define a negative timeout. A couple of handy
> constants and methods will also be defined (like {{UNDEFINED}} and
> {{DISABLED}}).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
