[ https://issues.apache.org/jira/browse/HTTPCLIENT-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108427#comment-16108427 ]
ASF subversion and git services commented on HTTPCLIENT-1865: ------------------------------------------------------------- Commit 8ec17b68222b7907852badc7d9efa9ebdaa18bf9 in httpcomponents-client's branch refs/heads/4.6.x from [~tjcelaya] [ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-client.git;h=8ec17b6 ] [HTTPCLIENT-1865] DefaultServiceUnavailableRetryStrategy does not respect HttpEntity#isRepeatable. > DefaultServiceUnavailableRetryStrategy does not respect > HttpEntity#isRepeatable > ------------------------------------------------------------------------------- > > Key: HTTPCLIENT-1865 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1865 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient (classic) > Affects Versions: 4.5.3 > Environment: Any environment > Reporter: Tomas Celaya > Fix For: 4.5.4 > > Attachments: > 0001-Only-retry-request-when-HttpEntity.isRepeatable-retu.patch, > 0002-ServiceUnavailableRetryExec-test-case-for-verifying-.patch > > > The {{HttpEntity}} interface provides a method for indicating whether or not > an entity can be automatically retried. While investigating an issue with > corruption of encrypted uploads in the [java-manta > library|https://github.com/joyent/java-manta] I discovered that requests were > being automatically retried in the event of a 503 response from the server. > Stepping through the execution path led me to discover that > {{ServiceUnavailableRetryExec}} does not check the supplied {{HttpRequest}} > to determine whether or not it can be safely retried. We've implemented a fix > within java-manta in our subcclass of > {{DefaultServiceUnavailableRetryStrategy}} but this seems like it could bite > others as well so I thought it would merit a bug report. > The included patch corrects this behavior. Checked that {{mvn verify}} > completes successfully. Please let me know if there are any questions or > other modifications that I need to make in order to contribute this patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org