[
https://issues.apache.org/jira/browse/HTTPCORE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146453#comment-16146453
]
ASF GitHub Bot commented on HTTPCORE-486:
-----------------------------------------
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/50
It is the change related to HTTPCORE-486.100000 is an arbitrary value.In my
test ,loop 100000 times
will take less than 3ms usually. 100000 is also the value netty used as the
similar logic .
> SingleCoreIOReactor.processPendingChannels and
> processPendingConnectionRequests should setting time limit
> ---------------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-486
> URL: https://issues.apache.org/jira/browse/HTTPCORE-486
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 5.0-alpha3
> Reporter: silver9886
>
> in processPendingChannels method
> while ((socketChannel = this.channelQueue.poll()) != null) {
> }
> do not have the time limit.If there are too many socketChannel in the
> channelQueue
> or there is channelQueue.add in the loop,the SingleCoreIOReactor time will be
> exhausted
> .That's will block the remaining work to do.
> I suggest using the following code:
> for (int i = 0 ;i < 100000 && (socketChannel = this.channelQueue.poll()) !=
> null;++i) {
> }
> the processPendingConnectionRequests method is the same
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
