[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski resolved HTTPCORE-488.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 5.0-beta1

Committed to master with changes. I also decided to not commit test cases due 
to their dependency on external hosts / availability of local ports and the 
fact that they were not really testing the fix in question.

Please review and close.

Oleg 

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -------------------------------------------------------------------------
>
>                 Key: HTTPCORE-488
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-488
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 5.0-alpha4
>            Reporter: silver9886
>            Priority: Minor
>             Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to