[ https://issues.apache.org/jira/browse/HTTPCLIENT-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266052#comment-16266052 ]
ASF subversion and git services commented on HTTPCLIENT-1883: ------------------------------------------------------------- Commit 7b7cdd1fd8a6a95e4461ccd3ba12f9501d51c496 in httpcomponents-client's branch refs/heads/4.6.x from [~olegk] [ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-client.git;h=7b7cdd1 ] HTTPCLIENT-1883: SystemDefaultCredentialsProvider to use https.proxy* system properties for origins with port 443 > Add https.proxy* documentation to HttpClientBuilder > --------------------------------------------------- > > Key: HTTPCLIENT-1883 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1883 > Project: HttpComponents HttpClient > Issue Type: Improvement > Affects Versions: 4.5.3 > Reporter: Marcel Stör > Labels: documentation > > To amend HTTPCLIENT-1128 I guess... > I find the list of [{{http.proxy*}} system properties in the type Javadoc for > {{HttpClientBuilder}}|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L140] > a bit misleading. > The JVM distinguishes between HTTP and HTTPS proxy settings (decide for > yourself how much sense that makes) but the Javadoc comment only talks about > {{http.proxy*}} system properties and not {{https.proxy*}} system properties. > One might come to the conclusion that by using {{#useSystemProperties()}} on > the builder you'd only get proxy support for HTTP connections but not for > HTTPS. > Adding a short note about that would be appropriate IMO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org