[ 
https://issues.apache.org/jira/browse/HTTPCORE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291700#comment-16291700
 ] 

Oleg Kalnichevski commented on HTTPCORE-439:
--------------------------------------------

@[~lewijw] We need to rewrite the patch. Please see HTTPCORE-499 for 
explanation. Feel free to resubmit the changes by moving header value 
comparison from {{#equals}} method to  {{HeaderGroup#removeHeader}} method or 
change the parameter signature of the method.

Oleg 

> Contribute BasicHeader override of equals() and hashCode()
> ----------------------------------------------------------
>
>                 Key: HTTPCORE-439
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-439
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: Contrib, HttpCore
>    Affects Versions: 5.0-alpha2
>         Environment: All
>            Reporter: John Lewis
>             Fix For: 5.0-alpha2
>
>
> When removing headers from a HeaderGroup, the header is only removed if the 
> header you are trying to remove is an object in the header list.  It seems it 
> would be better if headers were removed that matched the name and value of 
> one of the objects in the list.  To accomplish this, I have overridden the 
> equals and hashCode methods in BasicHeader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to