I just realized looking at my code that I am working with a pair of DefaultHttpServerIODispatch and DefaultHttpClientIODispatch, so I will apply the same changes to DefaultHttpClientIODispatch.
Gary On Sat, Jan 6, 2018 at 11:11 AM, Gary Gregory <[email protected]> wrote: > On Sat, Jan 6, 2018 at 3:47 AM, Oleg Kalnichevski <[email protected]> > wrote: > >> On Fri, 2018-01-05 at 15:56 -0700, Gary Gregory wrote: >> > Hi Oleg, >> > >> > Yes, subclassing affords all sorts of hacks/features and such. Can >> > you >> > please clarify: would you -1 adding these getters? >> > >> > Gary >> > >> >> Hi Gary >> >> Of course, I will not. I am just wondering if really want to cut a new >> release because of a single getter? >> > > Hi Oleg, > > There are other small changes in there already toward a 4.4.9: > > * HTTPCORE-494: Add image constants to ContentType. > * HTTPCORE-496: Add API org.apache.http.protocol. > UriPatternMatcher.entrySet(). > * HTTPCORE-497: Add API org.apache.http.nio.protocol. > UriHttpAsyncRequestHandlerMapper.getUriPatternMatcher(). > * HTTPCORE-499: Make interface Header extend NameValuePair > > I will proceed over the weekend with this change... > > Gary > > >> >> Oleg >> >> >> > On Fri, Jan 5, 2018 at 3:17 PM, Oleg Kalnichevski <[email protected]> >> > wrote: >> > >> > > On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote: >> > > > Hi Oleg, >> > > > >> > > > Not really, the ivars are private. >> > > > >> > > >> > > Nothing stops you from adding an instance variable to the subclass, >> > > does it not? >> > > >> > > Oleg >> > > >> > > >> > > > Gary >> > > > >> > > > On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <[email protected] >> > > > rg> >> > > > wrote: >> > > > >> > > > > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote: >> > > > > > Hi All, >> > > > > > >> > > > > > Are there any objects to my adding getters for: >> > > > > > >> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFact >> > > > > > ory >> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler >> > > > > > >> > > > > > I need to get the handler I stick in a >> > > > > > DefaultHttpServerIODispatch, >> > > > > > later. >> > > > > > >> > > > > > Gary >> > > > > >> > > > > Hi Gary >> > > > > >> > > > > You can also just subclass DefaultHttpServerIODispatch and >> > > > > provide >> > > > > the >> > > > > getter from the subclass. >> > > > > >> > > > > Oleg >> > > > > >> > > > > ------------------------------------------------------------- >> > > > > ---- >> > > > > ---- >> > > > > To unsubscribe, e-mail: [email protected] >> > > > > For additional commands, e-mail: [email protected] >> > > > > >> > > > > >> > > >> > > ----------------------------------------------------------------- >> > > ---- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >
