[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510888#comment-16510888
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1924:
-----------------------------------------------

I am yet to see a complex application that can gracefully recover from 
{{OutOfMemoryError}} without a restart. HttpClient does not attempt to handle 
{{java.lang.Error}} as they are considered fatal. If the JRE is in the 
{{OutOfMemoryError}} condition complex operations such as an attempt to release 
a connection back to the pool is likely to cause more of {{OutOfMemoryError}}.

What might be a reasonable thing to do in such situation is to flush the entire 
connection pool. I'll look into it.

Oleg

> connection leak issue when OutOfMemory
> --------------------------------------
>
>                 Key: HTTPCLIENT-1924
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1924
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (classic)
>    Affects Versions: 4.5.3, 4.5.4, 4.5.5
>            Reporter: wenqi.huang
>            Priority: Major
>
> *Yesterday, I found one of our java app is continuously throwing the 
> following exception:*
>  
> _org.apache.http.conn.ConnectionPoolTimeoutException: Timeout waiting for 
> connection from pool
>  at 
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.leaseConnection(PoolingHttpClientConnectionManager.java:313)
>  at 
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager$1.get(PoolingHttpClientConnectionManager.java:279)
>  at 
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:191)
>  at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
>  at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
>  at 
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
>  at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
>  at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
>  at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)_
> _at ....._
>  
> *So I look into the log, I found that before this exception occurs, there are 
> some `OutOfMemoryError`s (there are many different type of OutOfMemoryError, 
> I just copy&paste the most interesting one):* 
>  
> _java.lang.OutOfMemoryError: GC overhead limit exceeded_
>  _at 
> org.apache.http.util.CharArrayBuffer.substringTrimmed(CharArrayBuffer.java:466)_
>  _at 
> org.apache.http.message.BasicLineParser.parseProtocolVersion(BasicLineParser.java:163)_
>  _at 
> org.apache.http.message.BasicLineParser.parseStatusLine(BasicLineParser.java:366)_
>  _at 
> org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:158)_
>  _at 
> org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)_
>  _at 
> org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)_
>  _at 
> org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)_
>  _at 
> org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:165)_
>  _at 
> org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)_
>  _at 
> org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)_
>  _at 
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)_
>  _at 
> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)_
>  _at 
> org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)_
>  _at 
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)_
>  _at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)_
>  _at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)_
>  _at ........_
>  _at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)_
>  _at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)_
>  at java.lang.Thread.run(Thread.java:745)
>  
> *I look into the source code of httpClient, and found that when the 
> `OutOfMemoryError` is occur at the exacting place, the `HttpConnection` will 
> never be get released, so it will leak, and never to be reused any more, so 
> the following http call will be rejected,  that's why `Timeout waiting for 
> connection from pool` is *continuously trigged, even after my system have 
> been recovered from the `GC` problem, this problem will never auto back to 
> normal. so at this point to resolve this problem, my only choice is to fully 
> restart my system.** 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to