Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/68#discussion_r201268240
--- Diff:
httpcore5-testing/src/main/java/org/apache/hc/core5/testing/nio/IOReactorExecutor.java
---
@@ -85,7 +85,10 @@ public void execute(final IOSession session) {
}))) {
if (status.compareAndSet(Status.READY, Status.RUNNING)) {
- ioReactorRef.get().start();
+ if(this instanceof AsyncServer){
--- End diff --
@xiaohu-zhang This is terrible. Even for test classes we should not be
doing things like that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
