[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544520#comment-16544520
 ] 

ASF subversion and git services commented on HTTPCLIENT-1933:
-------------------------------------------------------------

Commit b97c7a08b261e4aa9c083d978ba93d4eb2d0fa7d in httpcomponents-client's 
branch refs/heads/master from [~olegk]
[ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-client.git;h=b97c7a0 
]

HTTPCLIENT-1933: fixed incorrect method names


> HttpAsyncClientBuilder misnamed interceptor methods
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1933
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1933
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async)
>         Environment: Affects both httpclient 5.0-beta1 and git master at the 
> time of writing.
>            Reporter: Alex Osborne
>            Priority: Minor
>             Fix For: 5.0 Beta2
>
>
> These two methods on HttpAsyncClientBuilder appear to have had the words 
> 'Request' and Response' swapped in their names as they actually take a 
> parameter of the opposite type:
> {code:java}
> addRequestInterceptorFirst(HttpResponseInterceptor interceptor)
> addResponseInterceptorLast(HttpRequestInterceptor interceptor){code}
> the other two interceptor methods seem to be named correctly:
> {code:java}
> addRequestInterceptorFirst(HttpRequestInterceptor interceptor)
> addResponseInterceptorLast(HttpResponseInterceptor interceptor)
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to