Github user ato commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/70#discussion_r202547255
  
    --- Diff: 
httpcore5/src/main/java/org/apache/hc/core5/http/nio/AsyncPushConsumer.java ---
    @@ -40,7 +41,7 @@
      */
     public interface AsyncPushConsumer extends AsyncDataConsumer {
     
    -    void consumePromise(HttpRequest promise, HttpResponse response, 
EntityDetails entityDetails) throws HttpException, IOException;
    +    void consumePromise(HttpRequest promise, HttpResponse response, 
EntityDetails entityDetails, HttpContext context) throws HttpException, 
IOException;
    --- End diff --
    
    Note this one definitely is a public API change. Is changing the interface 
like this acceptable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to