On Mon, 2018-11-19 at 20:53 -0700, Gary Gregory wrote: > Oleg, > > My test ran for 1.1m+ requests without failure. The fix is good to > go. >
Merged to master. Oleg > Gary > > On Mon, Nov 19, 2018, 11:19 Gary Gregory <[email protected] > wrote: > > > On Mon, Nov 19, 2018 at 11:12 AM Gary Gregory < > > [email protected]> > > wrote: > > > > > On Mon, Nov 19, 2018 at 7:28 AM Oleg Kalnichevski < > > > [email protected]> > > > wrote: > > > > > > > On Sun, 2018-11-18 at 18:50 +0100, Oleg Kalnichevski wrote: > > > > > On Sat, 2018-11-17 at 10:47 -0700, Gary Gregory wrote: > > > > > > Hi Oleg, > > > > > > > > > > > > I was able to reproduce the problem, the results are in the > > > > > > branch > > > > > > ggregory-async-reverse-proxy-problem, folder > > > > > > httpcore5/AsyncReverseProxyExample-run1. > > > > > > > > > > > > > > Gary > > > > > > > > Could you please pull the latest code from your branch and see > > > > if those > > > > changes make any difference to your test results locally? > > > > > > > > > > Hi Oleg, > > > > > > Good news: This change makes a HUGE difference: I was able to run > > > my app > > > for 995,352 requests over the course of 2 hours and 5 minutes > > > before > > > something went wrong when JMeter reported a 503, Service > > > Unavailable. > > > > > > > Now I know: Node.js/http-server crashed. I'll run the tests again. > > Node > > had been up for days. So it looks ever better for this fix :-) > > > > Gary > > > > > > > > > > I have no idea what happened there so I'll have to run the test > > > again but > > > the good news is that I did not get the content-length error. > > > > > > I did not try to test with the example reverse proxy because I > > > was able > > > to get SO much further than before running my app. > > > > > > Before your change and with this test, my app failed after 80 > > > requests > > > the last time I tested this past weekend. It feels like this > > > change makes a > > > massive different in my app. > > > > > > Can we get this change in master now? > > > > > > Thank you, > > > Gary > > > > > > > > > > Oleg > > > > > > > > > > > > > > > > ------------------------------------------------------------- > > > > -------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
