On Wed, Nov 21, 2018 at 3:08 PM Oleg Kalnichevski <[email protected]> wrote:
> On Wed, 2018-11-21 at 15:02 -0700, Gary Gregory wrote: > > On Wed, Nov 21, 2018 at 3:01 PM Oleg Kalnichevski <[email protected]> > > wrote: > > > > > On Wed, 2018-11-21 at 10:49 -0700, Gary Gregory wrote: > > > > Hi All: > > > > > > > > Do we really need two HandlerEntry classes? > > > > > > > > - org.apache.hc.core5.http.impl.bootstrap.HandlerEntry<T> > > > > - org.apache.hc.core5.http2.impl.nio.bootstrap.HandlerEntry<T> > > > > > > > > They are currently the same. Since they are both package private, > > > > using a > > > > single class would mean making one public. I suppose the question > > > > is: > > > > Do we > > > > need to hide this implementation detail so much as to make it > > > > _not_ a > > > > public class. > > > > > > > > Thoughts? > > > > > > > > Gary > > > > > > What would be the point of making this class or these classes > > > public? > > > Saving a few bytes of disc storage? > > > > > > > I'm just curious that's all; having two classes that are exactly the > > same > > but in two different packages looks a bit odd to me. > > > > What is the downside of having two package private classes that happen > to be the same? > This email thread ;-) writing it, discussing it. Code duplication is, generally speaking, not a great idea IMO. Gary > > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
