[ 
https://issues.apache.org/jira/browse/HTTPCORE-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700088#comment-16700088
 ] 

David Maplesden commented on HTTPCORE-563:
------------------------------------------

I have already finished the basic support, I created a PR for what I have done 
so far.  I wouldn't really call it finished yet, but I might not get the chance 
to work on it again for a few days so I thought I would raise the PR so you (or 
others) can have a look.  Please let me know if you have any feedback on the 
approach so far.  I am planning at least to add support for SOCKS 
username/password auth.  It currently only support SOCKS version 5, but since 
that is essentially what everyone uses it should be sufficient.

I am happy to add some tests but it is a hassle to create the server side SOCKS 
proxy to test against.

I have tested it pretty thoroughly in my own framework.  I am one of the core 
developers of [Charles Proxy|https://www.charlesproxy.com/] and we use the http 
client to drive a suite of thousands of unit tests.  I have been trying to 
upgrade to HttpClient 5.0 for the HTTP/2 support but the lack of SOCKS support 
in the async client killed many of our unit tests.


> Add SOCKS Proxy support to HttpCore NIO
> ---------------------------------------
>
>                 Key: HTTPCORE-563
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-563
>             Project: HttpComponents HttpCore
>          Issue Type: New Feature
>          Components: HttpCore NIO
>    Affects Versions: 5.0
>            Reporter: David Maplesden
>            Priority: Major
>
> I would like to add support for SOCKS proxies to HttpCore NIO classes.  SOCKS 
> proxies are already supported for 'classic' or 'blocking' IO via the standard 
> JVM support, however the JVM does not support SOCKS for nio Sockets and so 
> currently the HttpCore NIO classes cannot support a SOCKS proxy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to