Github user ok2c commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/98#discussion_r238059606
  
    --- Diff: 
httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java ---
    @@ -243,7 +243,8 @@ public void execute(final SSLIOSession sslSession) {
                             }
                         }
     
    -                }))) {
    +                },
    +                null))) {
    --- End diff --
    
    @rschmitt Do we really need an extra constructor parameter if it is always 
set to `null`? Otherwise looks good.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to