[ https://issues.apache.org/jira/browse/HTTPCLIENT-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723426#comment-16723426 ]
Philippe Mouawad commented on HTTPCLIENT-1956: ---------------------------------------------- Hello [~olegk], Thanks for handling this issue rapidly. Is there a particular procedure to build the project ? I cloned repo, checked out branch HTTPCLIENT-1956 and ran mvn clean install with 3.5.2 version, it fails with: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project httpcomponents-client: Too many files with unapproved license: 1 See RAT report in: /data/jmeter/httpcomponents-client/target/rat.txt -> [Help 1] I commented the plugin, it then fails with this because of SSL issue with JDK7: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project httpclient: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test failed: Plugin org.apache.maven.plugins:maven-surefire-plugin:2.22.1 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-surefire-plugin:jar:2.22.1 -> org.apache.maven.surefire:maven-surefire-common:jar:2.22.1: Failed to read artifact descriptor for org.apache.maven.surefire:maven-surefire-common:jar:2.22.1: Could not transfer artifact org.apache.maven.surefire:maven-surefire-common:pom:2.22.1 from/to central (https://repo.maven.apache.org/maven2): Received fatal alert: protocol_version -> [Help 1] Then I try to build with 1.8, it fails due to Api check: Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.16:check (checkAPIcompatibility) on project httpclient: Signature errors found. Verify them and ignore them with the proper annotation if needed. -> > Using a Proxy with HttpClient overwrite attributes stored under HttpContext > for the main request (not proxy one) > ---------------------------------------------------------------------------------------------------------------- > > Key: HTTPCLIENT-1956 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1956 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient (classic) > Affects Versions: 4.5.6 > Reporter: Philippe Mouawad > Priority: Major > Attachments: ProxyBug.java > > > At JMeter, we had this bug report on JMeter 5.0 which uses last GA version of > HTTPCORE- 4.4.10/HTTPCLIENT-4.5.6: > * [https://bz.apache.org/bugzilla/show_bug.cgi?id=62852] > * > The problem is that below method behaves differently if request is emitted > directly or through a Proxy: > * localContext.getAttribute(HttpCoreContext.HTTP_REQUEST); > If you run code below and inspect: > * localContext.getAttribute(HttpCoreContext.HTTP_REQUEST); > While you should get this (and you indeed get this if you don't use a proxy): > * The GET method > * All headers: > * X-Sleep:5 > * Host: [jmeter.apache.org:443|http://jmeter.apache.org:443/], > * User-Agent: Apache-HttpClient/4.5.6 (Java/1.8.0_161) > Instead you get: > * CONNECT method (the proxy related one) > * Partial Headers: > * Host: [jmeter.apache.org:443|http://jmeter.apache.org:443/], > * User-Agent: Apache-HttpClient/4.5.6 (Java/1.8.0_161) > In test case below: > * [http://localhost:8888|http://localhost:8888/] act as proxy (you can use > JMeter HTTP Test Script recorder to start a proxy or any proxy implementation > running on that port) > * [https://jmeter.apache.org|https://jmeter.apache.org/] is the target > website, but you can use any site you want > * X-Sleep is the custom header that is lost for example > > Find attached JUnit reproducing issue. > The impact can be wider -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org