On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski <[email protected]> wrote:
> On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote: > > Hi All: > > > > There is a bit of clean up left from a previous branch: > > > > ... > > > > > Is this OK to commit to master or does it need another branch or PR? > > > > There has to be another branch or PR now. > > This just highlights the fact that committing things away to a release > branch is a bad idea. > > Please create a branch and review the diff prior to merging or ask > someone else to do the review. > > In order to avoid the same mess we had with HTTPCORE-569 and HTTPCORE- > 570 it might be a good idea to not merge development branches early and > wait a day in case one might decide to re-work things, do more cleanups > or add javadocs. > Oleg, Please review branch UriPatternType-cleanup. Thank you, Gary > > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
