ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256864710
##########
File path:
httpclient/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java
##########
@@ -183,10 +190,23 @@ public URI getLocationURI(
/**
* @since 4.1
+ * @deprecated (4.5.8) use {@link #createLocationURI(String, boolean)}
*/
+ @Deprecated
protected URI createLocationURI(final String location) throws
ProtocolException {
+ return SENTINEL_URI;
+ }
+
+ /**
+ * @since 4.5.8
+ */
+ protected URI createLocationURI(final String location, final boolean
normalizeUri) throws ProtocolException {
Review comment:
@cstamas I think no normalization is required here at this point. The
decision whether of not the request URI requires normalization can be deferred
until the request execution. This would eliminate the need for
`createLocationURI` deprecation, the sentinel URI and lots of other things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
