On Thu, 2019-02-14 at 16:27 +0100, Michael Osipov wrote: > > Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr > > Von: "Oleg Kalnichevski" <ol...@apache.org> > > An: "HttpComponents Project" <dev@hc.apache.org> > > Betreff: Re: Re: Formal code reviews and PRs > > > > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > > > That sounds nice. > > > > > > > > > > Can we agree to add trivial changes to master directly, for > > > > > example, > > > > > if I > > > > > want to Javadoc a previously undocumented method? > > > > > > > > > > > > > I disagree rather strongly, especially if we want to keep > > > > master > > > > branch > > > > protected. Even trivial changes can break the build and > > > > introduce > > > > style > > > > violations. > > > > > > That's fair. That would mean we have a multibranch pipeline setup > > > on > > > Jenkins. > > > Do we? If it doesn't fail there, it should be good for a PR or > > > merge. > > > totally > > > fine by me. > > > > > > > We have got Travis-CI right now and the multibranch pipeline setup > > on > > ASF Jenkins is something I would like to look into. > > You shall be able to shamelessly steal the config from Maven TLP and > modify it. >
Shameless stealing is what I intend to do when it comes to good practices in CI. Oleg > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
