ok2c commented on a change in pull request #106: Immutable HttpEntity classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r257138883
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##########
@@ -59,29 +62,35 @@
* stored in an internal buffer
* @throws IOException in case of an I/O error
*/
- public SerializableEntity(final Serializable ser, final boolean bufferize)
throws IOException {
- super();
+ public SerializableEntity(
+ final Serializable ser, final boolean bufferize, final ContentType
contentType,
+ final String contentEncoding) throws IOException {
+ super(contentType, contentEncoding);
Args.notNull(ser, "Source object");
if (bufferize) {
createBytes(ser);
+ this.objRef = null;
Review comment:
@rschmitt Neither do it. I did not author this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
