ok2c commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257466146
########## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java ########## @@ -63,45 +114,23 @@ * @return String the extracted URI */ public String getURI(final HttpHost host, final HttpRequest req) { - if (isRelativeRequest(req)) { - return canonicalizeUri(String.format("%s%s", host.toString(), req.getRequestLine().getUri())); + try { + final URI uri = normalize(getRequestUri(req, host)); Review comment: @cstamas I cant help it. `return normalize(getRequestUri(req, host)).toASCIIString();` just looks ugly to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org