artem-smotrakov opened a new pull request #142: HTTPCLIENT-1969: Filter out weak cipher suites URL: https://github.com/apache/httpcomponents-client/pull/142 This is a port of #140 to the master branch: - The changes in SSLConnectionSocketFactory.java are the same - I see that httpclient5 has slightly different structure for tests. I have updated `org.apache.hc.client5.testing.sync.TestSSLSocketFactory` with new test cases with a local server but could not add tests for `isWeakCipherSuite()` method because of different package name. The test for this method have been added to new `org.apache.hc.client5.http.ssl.TestSSLSocketFactory` test. Another options is to make `isWeakCipherSuite()` method public, and them move all test cases to `org.apache.hc.client5.testing.sync.TestSSLSocketFactory`. But not sure if `isWeakCipherSuite()` method should be public. Let me know if it needs to be updated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
