ok2c commented on a change in pull request #143: Changed route tracking of
proxy to not default to false
URL:
https://github.com/apache/httpcomponents-client/pull/143#discussion_r265252004
##########
File path:
httpclient/src/main/java/org/apache/http/impl/execchain/MainClientExec.java
##########
@@ -404,7 +404,7 @@ void establishRoute(
timeout > 0 ? timeout : 0,
context);
final HttpHost proxy = route.getProxyHost();
- tracker.connectProxy(proxy, false);
+ tracker.connectProxy(proxy, route.isSecure());
Review comment:
@gknapowski it should most likely be `route.isSecure() &&
!route.isTunnelled()`, that is a direct (non-tunneled) connection to the proxy
can be considered secure if the route is considered secure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
