[ https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822065#comment-16822065 ]
Varun Nandi commented on HTTPCLIENT-1983: ----------------------------------------- [~olegk] The current behavior breaks so many customers upgrading from 4.5.6. I think disabling normalization is good default behavior as it doesn't break customers moving from 4.5.6. The customers using 4.5.7 and 4.5.8 (who will be effected by this change) should be relatively small compared to customers using 4.5.6 or less. So I think changing normalization default behavior from true to false is reasonable. > URIBuilder normalization change is significantly breaking > --------------------------------------------------------- > > Key: HTTPCLIENT-1983 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983 > Project: HttpComponents HttpClient > Issue Type: Bug > Affects Versions: 4.5.7, 4.5.8 > Reporter: Ryan Schmitt > Priority: Major > Fix For: 4.5.9 > > Time Spent: 20m > Remaining Estimate: 0h > > In 4.5.7, the behavior of URIBuilder changed in order to address > HTTPCLIENT-1960. Since that version was released, I have seen a concerning > number of users complain that this change has broken their code (see issue > links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to > allow users to opt in to the old behavior, but the new behavior is what they > will get by default. This problem is difficult to work around for developers > who cannot exercise exact control over the runtime version of HttpClient: the > method they need might not be there, and if it is, it needs to be invoked > reflectively, or in a way that tolerates a {{NoSuchMethodError}}. > For the sake of compatibility, I propose that we change the default value of > {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line > only; the 5.0.x line, as well as any future 4.6.x line, will normalize by > default (if an option is needed at all). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org