varunnvs92 opened a new pull request #146: Fix bug in URIBuilder#isPathEmpty method URL: https://github.com/apache/httpcomponents-client/pull/146 isPathEmpty should verify if encodedPath member is an empty string. Otherwise, [this code](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java#L229) in URIUtils.rewriteURI will evaluate to false when normalization is disabled. Before 4.5.6, URIUtils.rewriteURI method used [TextUtils#isEmpty method](https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java#L42) which checked for both null and empty string case. * Added a new unit test. The test failed before including the empty string check
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
