On Tue, Jun 11, 2019 at 5:37 PM Oleg Kalnichevski <[email protected]> wrote:
> On Tue, 2019-06-11 at 16:48 -0400, Gary Gregory wrote: > > Hi All: > > > > Here are two PRs for http-core and http-client for Http2* -> H2* > > > > https://github.com/apache/httpcomponents-core/pull/130 > > https://github.com/apache/httpcomponents-client/pull/152 > > > > If you look at these, the next item that stands out are the Http1* > > types > > which feel (to me) should be renamed to H1*. Ironically, this would > > leave > > the H1Config class alone, which started this set of threads. > > > > I then wonder and hope that all classes that start with Http* are > > generic > > to either H1 or H2. What the truth there? > > > > Gary > > Gary > > Could we please rename `H1` to `Http1` and `Http2` to H2 and move on? > I think should start by merging the two PRs above. This will do the Http2* to H2* change. Then I'd like to hear from the folks who have kind enough to opine. I feel this is important since these names are going to live on for a long time. This will also give folks a change to look at master with the merged PRs if they have not peeked at the PRs themselves. Thank you, Gary > Oleg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
