ok2c commented on a change in pull request #137: HTTPCORE-589 Fix LaxConnPool
to ensure pending requests assigned connections
URL:
https://github.com/apache/httpcomponents-core/pull/137#discussion_r313913891
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/pool/LaxConnPool.java
##########
@@ -481,12 +485,18 @@ public void release(final PoolEntry<T, C> releasedEntry,
final boolean reusable)
}
}
else {
- deallocatePoolEntry();
+ disposePoolEntry(releasedEntry);
}
+ releaseSeqNum.incrementAndGet();
servicePendingRequest();
}
+
private void servicePendingRequest() {
+ servicePendingRequests(false);
+ }
+
+ private void servicePendingRequests(final boolean wholeQueue) {
Review comment:
@coxlinton Let's use an enum here instead of a boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
