s1monw commented on issue #138: Execute Socket[Channel]#connect under 
doPrivileged
URL: 
https://github.com/apache/httpcomponents-core/pull/138#issuecomment-521560912
 
 
   > Could you please rebase your PR off the latest 4.4.x? 
   
   I can do that. I do wonder why you don't use githubs `squash and merge` from 
the merge button. I am not sure if it's the default for you but the little 
drop-down on the merge button gives you the option that way you don't get a 
merge commit and you don't need to rebase. you can also then edit the commit 
message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to