bekker commented on a change in pull request #162: Modify RequestConfig Javadoc
URL:
https://github.com/apache/httpcomponents-client/pull/162#discussion_r316756683
##########
File path:
httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java
##########
@@ -295,11 +293,11 @@ public int getConnectTimeout() {
/**
* Defines the socket timeout ({@code SO_TIMEOUT}) in milliseconds,
- * which is the timeout for waiting for data or, put differently,
+ * which is the timeout for waiting for data or, put differently,
* a maximum period inactivity between two consecutive data packets).
* <p>
* A timeout value of zero is interpreted as an infinite timeout.
- * A negative value is interpreted as undefined (system default).
+ * A negative value is interpreted as undefined.
Review comment:
@garydgregory You're right. I should add more info, not removing it.
But I'm not sure about meaning of 'undefined' here - is it 'undefined
behavior'? Then there should be a warning about unexpected results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
